Skip to content

Add albedo to get_nasa_power variable map#2753

Merged
kandersolar merged 4 commits into
mainfrom
AdamRJensen-patch-1
May 20, 2026
Merged

Add albedo to get_nasa_power variable map#2753
kandersolar merged 4 commits into
mainfrom
AdamRJensen-patch-1

Conversation

@AdamRJensen
Copy link
Copy Markdown
Member

@AdamRJensen AdamRJensen commented May 10, 2026

  • I am familiar with the contributing guidelines
  • I attest that all AI-generated material has been vetted for accuracy and is in compliance with the pvlib license
  • Tests added
  • Adds description and name entries in the appropriate "what's new" file in docs/sphinx/source/whatsnew for all changes. Includes link to the GitHub Issue with :issue:`num` or this Pull Request with :pull:`num`. Includes contributor name and/or GitHub username (link with :ghuser:`user`).
  • New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.
  • Pull request is nearly complete and ready for detailed review.
  • Maintainer: Appropriate GitHub Labels (including remote-data) and Milestone are assigned to the Pull Request and linked Issue.

The NASA POWER dataset has four albedo parameters (link). I believe the ALLSKY_SRF_ALB is the correct parameter for albedo for solar energy applications. This PR adds it to the variable map.

image

@AdamRJensen AdamRJensen added the io label May 10, 2026
@echedey-ls echedey-ls added enhancement remote-data triggers --remote-data pytests labels May 10, 2026
@kandersolar kandersolar added this to the v0.15.2 milestone May 20, 2026
Copy link
Copy Markdown
Member

@kandersolar kandersolar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose it is the correct one, although it's not clear to me what the "Adjusted" quantity refers to specifically.

Worth a what's new entry?

Test failure is not related (meteonorm metadata).

Comment thread docs/sphinx/source/whatsnew/v0.15.2.rst Outdated
Co-authored-by: Kevin Anderson <kevin.anderso@gmail.com>
@kandersolar kandersolar merged commit 6fd4b07 into main May 20, 2026
31 checks passed
@kandersolar kandersolar deleted the AdamRJensen-patch-1 branch May 20, 2026 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement io remote-data triggers --remote-data pytests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants